Clash Royale CLAN TAG

Logic for newlines in the Chrome JavaScript console

I'm building my own application that has a JavaScript backend for user scripting, and am implementing something similar to Chrome's JavaScript console.

One thing that's puzzling me is the logic that Chrome uses to decide when the return key triggers the command to be executed, and when it auto continues to a new line.

For example if you type

function blah() { <return>

function blah() { <return>

then it continues on to the next line to allow you to continue typing the function, whereas

function blah() {] <return>

function blah() {] <return>

immediately gives a parse error (so it's not as simple as just keeping count of open bracket pairs)

Does anyone have any hits (or is anyone familiar enough with the Chromium source who's able to point me to that particular logic in their codebase)

so it's not as simple as just keeping count of open bracket pairs

{

]

1 Answer
1

Here's the source that decides what to do when Enter is pressed (thanks, wOxxOm):

async _enterKeyPressed(event) {
if (event.altKey || event.ctrlKey || event.shiftKey)
return;

event.consume(true);

this.clearAutocomplete();

const str = this.text();
if (!str.length)
return;

if (!this._isCaretAtEndOfPrompt()) {
await this._appendCommand(str, true);
return;
}

if (await ObjectUI.JavaScriptAutocomplete.isExpressionComplete(str))
await this._appendCommand(str, true);
else
this._editor.newlineAndIndent();
this._enterProcessedForTest();
}


And here's the source that determines if an expression is complete:

static async isExpressionComplete(expression) {
const currentExecutionContext = UI.context.flavor(SDK.ExecutionContext);
if (!currentExecutionContext)
return true;
const result =
await currentExecutionContext.runtimeModel.compileScript(expression, '', false, currentExecutionContext.id);
if (!result.exceptionDetails)
return true;
const description = result.exceptionDetails.exception.description;
return !description.startsWith('SyntaxError: Unexpected end of input') &&
!description.startsWith('SyntaxError: Unterminated template literal');
}


If my interpretation is correct, it looks like DevTools just compiles the expression and uses that result to determine if the expression is complete. If there's exceptions or errors, it's not complete.

By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.